Fixed #29112 -- Allowed using QuerySet.update() to update specific keys in nested JSONField. #13152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Continuing from #9715 |
priyanshsaxena
force-pushed
the
ticket_29112_again
branch
from
20ad276 to
238247e
Compare
priyanshsaxena
force-pushed
the
ticket_29112_again
branch
from
238247e to
7cba4cf
Compare
|
@priyanshsaxena Thanks 👍. Please provide solution for all builtin backends. |
bpartridge
reviewed
Oct 27, 2020
| from django.contrib.postgres.functions import JSONBSet | ||
| from django.db.models import Value | ||
| val = JSONBSet( | ||
| field.name, Value('{%s}' % hierarchy), Value('"%s"' % val), Value(False) |
There was a problem hiding this comment.
Should the val argument be the following to accommodate primitive values that aren't strings, and that don't necessarily stringify into valid JSON (such as booleans)? Test coverage should likely also be expanded accordingly. We're using the following in our codebase for the third argument to jsonb_set:
Cast(Value(json.dumps(value)), output_field=JSONField())
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific keys can be updated within a nested JSONField by specifying
the path and new value as arguments to the update() method, just like
the syntax used in Lookups.