Fixed #31829 -- Used JSONField __contains lookup on key transforms. #13238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
force-pushed
the
ticket_31829
branch
2 times, most recently
from
6121960 to
760c73c
Compare
felixxm
reviewed
Jul 27, 2020
felixxm
reviewed
Jul 27, 2020
felixxm
changed the title
|
@laymonage Thanks 👍 I rebased from master and pushed small edits. |
timgraham
reviewed
Jul 28, 2020
| @@ -695,8 +714,11 @@ def test_contains_contained_by_with_key_transform(self): | |||
| )), | |||
| ), | |||
| ] | |||
| # PostgreSQL requires a layer of nesting. | |||
| if connection.vendor != 'postgresql': | |||
There was a problem hiding this comment.
This should be a feature flag as CockroachDB (which tries to emulate PostgreSQL in a lot of ways) has the same restriction.
There was a problem hiding this comment.
Agreed, Do you have any name suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #31829.
I made a mistake and created a
KeyTransformContainsthat's based onlookup.Contains. This makes thecontainslookup to not use JSON containment logic when it's performed on aKeyTransform. Therefore, it's incompatible with the previous PostgreSQL implementation, which uses the overridden lookup.This PR fixes that by removing
KeyTransformContains.The customJSON_CONTAINSfunction on SQLite has also been extended to follow the rules ofJSON_CONTAINSon MySQL. On Oracle, the implementation is turned into a chainedKeyTransformExactlookup if therhsis adict, otherwise it falls back to the builtinlookup.Contains.I also added notes to the docs, but I'm not sure if that's necessary.