Skip to content

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Aug 25, 2020

This resolves an issue on databases without a native JSONField (MariaDB, MySQL, SQLite, Oracle), where values must be wrapped.

Thanks Sébastien Pattyn for the report.

ticket-31936

@felixxm
Copy link
Member Author

felixxm commented Aug 25, 2020

@sebastienpattyn93 Can you confirm that this patch fixes your issue?

@felixxm felixxm requested a review from a team August 25, 2020 06:29
Copy link
Member

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixxm
Copy link
Member Author

felixxm commented Aug 25, 2020

@adamchainz Thanks 👍 Patch updated.

This resolves an issue on databases without a native JSONField
(MariaDB, MySQL, SQLite, Oracle), where values must be wrapped.

Thanks Sébastien Pattyn for the report.
@felixxm felixxm changed the title Fixed #31936 -- Fixed __in lookup on key tranforms for JSONField. Fixed #31936 -- Fixed __in lookup on key transforms for JSONField. Aug 26, 2020
@felixxm felixxm merged commit 1251772 into django:master Aug 26, 2020
@felixxm felixxm deleted the issue-31936 branch August 26, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants