Skip to content

Conversation

orf
Copy link
Contributor

@orf orf commented Mar 7, 2021

See here for context.

The exact wording probably needs refining, but the jist of the implementation is there.

Base automatically changed from master to main March 9, 2021 06:22
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @orf — I like this. We should probably give it a run as it is. Thanks!

I'm +1 here — let me just confirm with @felixxm

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orf Thanks 👍

Personally, I don't like automatic messages but I'm also not against them. Feel-free to merge this.

@felixxm felixxm changed the title Add a message to new contributors when they open a PR Added GitHub action with welcome message for first-time contributors. Mar 12, 2021
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orf Thanks 👍 I pushed minor edits.

We tested this message in felixxm#2 (Thanks @MarkusH ⭐).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use {}:

Suggested change
Hello @${{ github.event.pull_request.user.login }}! Thank you for your contribution 💪
Hello @{}! Thank you for your contribution 💪

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@MarkusH
Copy link
Member

MarkusH commented Mar 12, 2021

❤️ But can we sneak in a 🦄 emoji in the message?

@felixxm
Copy link
Member

felixxm commented Mar 12, 2021

heart But can we sneak in a unicorn emoji in the message?

I like 🦄 but I think the welcome message it's fine without it 😉

@felixxm felixxm merged commit a464ead into django:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants