Skip to content

Conversation

tiagohonorato
Copy link
Contributor

@tiagohonorato tiagohonorato commented Mar 12, 2021

This adds an implementation for Origin.__repr__() and it is part of ticket-24121

Signed-off-by: Tiago Honorato tiagohonorato1@gmail.com

@github-actions
Copy link

Hello @tiagohonorato! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

Copy link
Contributor

@orf orf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t forget to add the PR to the trac ticket!

@tiagohonorato tiagohonorato requested a review from orf March 15, 2021 18:27
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagohonorato Thanks for this patch 👍 Can you also prepare __repr__() for Template class? (it's in the same file)

@tiagohonorato
Copy link
Contributor Author

@tiagohonorato Thanks for this patch +1 Can you also prepare __repr__() for Template class? (it's in the same file)

@felixxm for sure! :)

@felixxm felixxm changed the title Refs #24121 -- Added __repr__() to Origin Refs #24121 -- Added __repr__() to Origin and Template. Mar 17, 2021
@felixxm
Copy link
Member

felixxm commented Mar 17, 2021

@tiagohonorato Thanks 👍 Welcome aboard ⛵

@felixxm felixxm removed the request for review from orf March 17, 2021 06:43
@felixxm felixxm merged commit 4f4f770 into django:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants