Fixed #32686 -- Removed unnecessary semicolon on collected multiline SQL for RunSQL. #14314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngnpope
suggested changes
Apr 26, 2021
There was a problem hiding this comment.
Hi @hannseman. Thanks for this - I've just got a few minor suggestions.
hannseman
force-pushed
the
runsql-semicolon
branch
from
da0aeee to
65dbe9c
Compare
felixxm
changed the title
felixxm
force-pushed
the
runsql-semicolon
branch
from
65dbe9c to
eab71f7
Compare
|
@hannseman Thanks 👍 I pushed extra tests to a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/32686