Fixed #32807 -- Fixed JSONField crash when redisplaying None values. #14558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @strokirk! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
smithdc1
reviewed
Jun 24, 2021
felixxm
changed the title
felixxm
reviewed
Jun 25, 2021
Thanks to Alex Hill for the initial patch.
|
@strokirk Thanks 👍 Welcome aboard ⛵ |
|
Thanks! 🎉 |
laymonage
added a commit
to laymonage/django-jsonfield-backport
that referenced
this pull request
Aug 21, 2021
laymonage
added a commit
to laymonage/django-jsonfield-backport
that referenced
this pull request
Aug 21, 2021
laymonage
added a commit
to laymonage/django-jsonfield-backport
that referenced
this pull request
Aug 21, 2021
laymonage
added a commit
to laymonage/django-jsonfield-backport
that referenced
this pull request
Aug 21, 2021
laymonage
added a commit
to laymonage/django-jsonfield-backport
that referenced
this pull request
Aug 21, 2021
laymonage
added a commit
to laymonage/django-jsonfield-backport
that referenced
this pull request
Aug 21, 2021
laymonage
added a commit
to laymonage/django-jsonfield-backport
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://code.djangoproject.com/ticket/32807
This change prevents an exception from being raised during form rendering when a JSONField is missing from form data, bringing the behaviour of JSONField in line with other fields in this case. Specifically, a blank field is rendered, accompanied by a validation error if the field is required.
Thanks to @AlexHill for the initial patch.
This takes over where #13844 left off.
Ping @felixxm for review.