Fixed #6135 -- Added autoescape_aware decorator.

[chinmoy12c]

Ticket reference: https://code.djangoproject.com/ticket/6135

[chinmoy12c]

@felixxm can you take a look at this. Thanks :).

[carltongibson]

Thanks for picking this up @chinmoy12c.

I have to say that after 14 years I think we should probably close this as wontfix. 😬

I think the new decorator is likely to cause more confusion that it'll solve.

Specifically, it's only going to be appropriate for filters already marked @stringfilter — that's fine, in theory, but that's not documented at all — and it's going to be anything but clear to document — and we're going to see a whole load of reports saying @autoescape_aware doesn't work with my filter.

There's already a way to do this, and the proposed decorator isn't sufficiently robust to cover all cases.

Also, as evidenced by those 14 years, I'm not convinced the saving is all that great:

    if autoescape: 
        esc = conditional_escape 
    else: 
        esc = lambda x: x 

… OK, yes. It's slightly repetitive. If it really bothered me I could write a make_escape() factory function to remove the duplication. But, on the other hand, it's clear: there's no question of what the behaviour is, and I don't have to go looking into the source to see how the parameters get applied.

Summary, I'm not at all convinced the proposed decorator pays its way.
🤔

[carltongibson]

Closing as per ticket. Thanks @chinmoy12c. Sorry. 🎁