Fixed #33474 -- Added __slots__ to Variable and FilterExpression. #15378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smithdc1 This is (a part of) the idea you provided on the other PR in case you wanted to take a gander and shoulder some of the blame ;) as I alluded, same oeuvre. |
felixxm
force-pushed
the
tickets/33474
branch
from
dc28ef7 to
84418ba
Compare
|
@kezabelle Thanks 👍 |
felixxm
changed the title
__slots__ definitions to Variable and FilterExpression
|
Looks like @felixxm is way ahead of me here 👍. This makes sense to me, looks good. I had a browse on GitHub and couldn't see any cases of folk doing things which this change would cause a breaking change from them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket is 33474, opening PR to get CI sign-off before it's even considered for accepting.
According to
pympler, this changes the size of a simple instantiatedVariablefrom592to216, and aFilterExpressioncontaining the sameVariablefrom1000to368usingpython3.10. I've not observed any particular difference in runtime performance, though it would be ideal if anyone else could demonstrate there is one, better or worse.Note that in a production environment where the cached template loaders are ordinarily used, this is just going to be reducing the high-water-mark for keeping those around in memory.