Fixed #33607 -- Made PostgresIndex.create_sql() respect the "using" argument.

[alexei]

https://code.djangoproject.com/ticket/33607

The TL;DR is PostgresIndex.create_sql accepts a using argument but throws it away. This update fixes that and passes the argument to the underlying method.

[alexei]

I noticed subclasses of IndexTestMixin declare an index_class attribute but don't make use of it. Is this chance or design? I thought it was the former and wanted to clean them up, but am unsure about the policy here.

[felixxm]

I noticed subclasses of IndexTestMixin declare an index_class attribute but don't make use of it. Is this chance or design? I thought it was the former and wanted to clean them up, but am unsure about the policy here.

index_class is used in tests inherited from IndexTestMixin.

[felixxm]

@alexei Thanks 👍 I left comments.

[alexei]

I noticed subclasses of IndexTestMixin declare an index_class attribute but don't make use of it. Is this chance or design? I thought it was the former and wanted to clean them up, but am unsure about the policy here.

index_class is used in tests inherited from IndexTestMixin.

That's what I'm saying: it's not. Only the IndexTestMixin methods use index_class, while the subclasses repeat the class.

[felixxm]

I noticed subclasses of IndexTestMixin declare an index_class attribute but don't make use of it. Is this chance or design? I thought it was the former and wanted to clean them up, but am unsure about the policy here.

index_class is used in tests inherited from IndexTestMixin.

That's what I'm saying: it's not. Only the IndexTestMixin methods use index_class, while the subclasses repeat the class.

I don't anything wrong or unusual in this pattern 🤔

[alexei]

I don't anything wrong or unusual in this pattern 🤔

It breaks the open-closed principle. If e.g. GinIndexTests didn't hard code the index class, I could've extended GinIndex for the dummy index and GinIndexTests for its tests 🤷‍♂️

[felixxm]

It breaks the open-closed principle. If e.g. GinIndexTests didn't hard code the index class, I could've extended GinIndex for the dummy index and GinIndexTests for its tests.

... but GinIndexTests was never intended to be extended. Extending GinIndexTests for DummyIndex would create even more unnecessary (and/or redundant) tests for DummyIndex that we don't need/want.

[felixxm]

@alexei Welcome aboard ⛵