Refs #30426 -- Updated XFrameOptionsMiddleware docstring.#15644
Merged
felixxm merged 1 commit intodjango:mainfrom Apr 29, 2022
c-w:patch-1
Merged
Refs #30426 -- Updated XFrameOptionsMiddleware docstring.#15644felixxm merged 1 commit intodjango:mainfrom c-w:patch-1
felixxm merged 1 commit intodjango:mainfrom
c-w:patch-1
Conversation
In #11751 the `X_FRAME_OPTIONS` default was changed from `SAMEORIGIN` to `DENY`, however the docstring of `XFrameOptionsMiddleware` wasn't updated which leads to confusion as the documentation and behavior differ. This pull request updates the docstring to fix the inconsistency.
|
Hello @c-w! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
felixxm
changed the title
Member
|
@c-w Thanks 👍 Welcome aboard ⛵ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11751 the
X_FRAME_OPTIONSdefault was changed fromSAMEORIGINtoDENY, however the docstring ofXFrameOptionsMiddlewarewasn't updated which leads to confusion as the documentation and behavior differ. This pull request updates the docstring to fix the inconsistency.