Fixed #34033 -- Improved accessibility of switch button for dark mode in the admin. #16085
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
FlorianPerucki
force-pushed
the
ticket_34033
branch
from
148cd7b to
032970b
Compare
There was a problem hiding this comment.
👍 all working as expected (tested in Safari 15.6.1 macOS 12.5.1 w/ VoiceOver). Note for context @FlorianPerucki and I worked on this together in person.
This could perhaps be written a bit more concisely but if we did so I’d prefer to change the whole component – so not this time around.
cc @felixxm – good to go! 🚢
… in the admin. Bug in bc7aa2a. Thanks Thibaud Colas for the report and review.
felixxm
force-pushed
the
ticket_34033
branch
from
032970b to
c5f5c71
Compare
felixxm
changed the title
|
@FlorianPerucki Thanks 👍 Welcome aboard ⛵ @thibaudcolas Thanks for the report and review ⭐ |
|
buildbot, test on selenium. |
|
Merged in 2c7c22f. |
3 participants
aria-hidden="true"on the relatedsvgelements in order to always hide icons for screen reader usersWorked on this PR by pairing with @thibaudcolas