-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
Fixed #26975 -- Clarified how Django looks for fixture files. #16104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
91bf11e
to
db8af19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
db8af19
to
9e84655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These additional changes look good to me.
9e84655
to
e471f8c
Compare
@filiplajszczak Thanks for this patch 👍 Welcome aboard ⛵ I pushed tiny edits. |
Co-Authored-By: Daniel Brotsky <dev@brotsky.com>
e471f8c
to
fe6f4be
Compare
@felixxm Commit message is definitely better now. I was hesitant about |
@filiplajszczak I much appreciate that you picked this up and fixed it; I got busy at work (a long time ago) but always felt bad that I never got back to it. I'm very appreciative of the co-author credit. |
Explain the different effects of relative and absolute paths on
loaddata
.Suggest that fixture files be namespaced, which makes the documentation for fixtures consistent with that for templates and static files.
Based on previous proposal from PR #6996 by @brotskydotcom made more howto-like and less reference-like.