Skip to content

Conversation

filiplajszczak
Copy link
Contributor

Explain the different effects of relative and absolute paths on loaddata.

Suggest that fixture files be namespaced, which makes the documentation for fixtures consistent with that for templates and static files.

Based on previous proposal from PR #6996 by @brotskydotcom made more howto-like and less reference-like.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

Copy link
Contributor

@evildmp evildmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Copy link
Contributor

@evildmp evildmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additional changes look good to me.

@felixxm felixxm changed the title Fixed #26975 -- update initial data howto about where fixtures are loaded from. Fixed #26975 -- Clarified how Django looks for fixture files. Sep 25, 2022
@felixxm
Copy link
Member

felixxm commented Sep 25, 2022

@filiplajszczak Thanks for this patch 👍 Welcome aboard ⛵

I pushed tiny edits.

Co-Authored-By: Daniel Brotsky <dev@brotsky.com>
@filiplajszczak
Copy link
Contributor Author

@felixxm Commit message is definitely better now. I was hesitant about Co-authored-by: as I was not sure if the author of the original PR would like it. That's why I made it more vague, but If you fill that I was too scrupulous, let it be.

@brotskydotcom
Copy link
Contributor

@filiplajszczak I much appreciate that you picked this up and fixed it; I got busy at work (a long time ago) but always felt bad that I never got back to it. I'm very appreciative of the co-author credit.

cc @felixxm @evildmp

@felixxm felixxm merged commit fe6f4be into django:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants