Fixed #34556 -- Doc'd that StreamingHttpResponse accepts memoryviews and strings iterators. #16844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing given the ticket was closed as invalid, if the ticket gets accepted, please feel free to re-open! Thanks. |
|
Re-opening following the conversation in the ticket. |
nessita
changed the title
nessita
requested changes
May 10, 2023
|
Done. |
nessita
approved these changes
May 10, 2023
|
One last request @Alexerson before I merge this, could you please squash all commits into one? |
felixxm
reviewed
May 11, 2023
felixxm
changed the title
…and strings iterators.
|
Pushed minor edit following review from Mariusz and will land once tests are ran. Thank you! |
|
Sorry, got a busy day yesterday. Thanks for taking care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for https://code.djangoproject.com/ticket/34556
This is a pretty minor change, but allows to explicitly tell what the code is doing.