Skip to content

Conversation

angelicaferlin
Copy link

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

If your code uses caching or proactively updates data in the cache, consider
disabling ATOMIC_REQUESTS to avoid unexpected behavior. Similarly, if your
code assumes that database changes are visible outside of the transaction,
you may need to update your code to take transactions into account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen Simon's suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first reaction is that this warning says the same thing multiple times without providing any feasible solution 🤔 e.g. it doesn't mention transaction.on_commit.

@felixxm
Copy link
Member

felixxm commented May 26, 2023

@angelicaferlin Do you have time to keep working on this?

@angelicaferlin
Copy link
Author

@angelicaferlin Do you have time to keep working on this?

Sorry, I don´t have time and have deassigned myself from the ticket. Anyone interested can pick up from here!

@nessita
Copy link
Contributor

nessita commented May 29, 2023

Closing following the message from the author, and resetting flags in the ticket so hopefully someone else picks this up.

@nessita nessita closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants