Fixed #34791 -- Fixed incorrect Prefetch()'s cache for singly related objects. #17207
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
MaxDude132
force-pushed
the
ticket_34791
branch
from
8fc8b19 to
ab26977
Compare
MaxDude132
force-pushed
the
ticket_34791
branch
from
ab26977 to
6681b9b
Compare
|
@charettes There seems to be a test failing, but I don't think it has anything to do with the changes I made? Could it be a flaky (I don't know if you have many of those on django)? |
|
@MaxDude132 I confirm that it is flaky and not related to your changes. |
|
@charettes I believe it is ready to merge |
MaxDude132
force-pushed
the
ticket_34791
branch
from
6681b9b to
698fdd6
Compare
|
@charettes All changes were addressed. Thanks a lot for your help on this, it is much appreciated as this was my first real deep-dive into the Django code |
|
@MaxDude132 glad I could help, you did a good job at identifying the root cause and providing a patch. |
… objects. Changed the cache name used for singly related objects to be the to_attr parameter passed to a Prefetch object. This fixes issues with checking if values have already been fetched in cases where the Field already has some prefetched value, but not for the same model attr.
felixxm
changed the title
|
@MaxDude132 Thanks 👍 Welcome aboard ⛵ |
felixxm
force-pushed
the
ticket_34791
branch
from
698fdd6 to
254df3a
Compare
3 participants
Changed the cache name used for singly related objects to be the to_attr parameter passed to a Prefetch object. This fixes issues with checking if values have already been fetched in cases where the Field already has some prefetched value, but not for the same model attr.