Skip to content

Fixed #34821 -- Prevented DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings from mutating the main STORAGES. #17236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fixed #34821 -- Prevented DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings from mutating the main STORAGES. #17236

merged 1 commit into from
Sep 11, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Sep 8, 2023

ticket-34821, check out logs.

Regression in 6b965c6.

@felixxm felixxm requested a review from a team September 8, 2023 08:35
jacobtylerwalls
jacobtylerwalls reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get by without setattr?

@felixxm
Fixed #34821 -- Prevented DEFAULT_FILE_STORAGE/STATICFILES_STORAGE se…
99ef5c6 
…ttings from mutating the main STORAGES.

Regression in 6b965c6.
@felixxm
Copy link
Member Author

felixxm commented Sep 8, 2023

@jacobtylerwalls Thanks for checking 👍 Updated.

David-Wobrock
David-Wobrock approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@David-Wobrock David-Wobrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Would it make sense to add some safe guard to avoid mutating self.STORAGES?

@felixxm
Copy link
Member Author

felixxm commented Sep 10, 2023

👍

Would it make sense to add some safe guard to avoid mutating self.STORAGES?

Thanks for checking 👍 Do you think more is needed than current tests?

@David-Wobrock
Copy link
Member

👍
Would it make sense to add some safe guard to avoid mutating self.STORAGES?

Thanks for checking 👍 Do you think more is needed than current tests?

Not necessarily. I had more in mind something in the runtime, that would raise a warning or exception every time we modify self.STORAGES. But that could introduce a bit of unnecessary overhead 🤔

@felixxm felixxm merged commit a7c73b9 into django:main Sep 11, 2023
@felixxm felixxm deleted the issue-34821 branch September 11, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

+1 more reviewer

@David-Wobrock David-Wobrock David-Wobrock approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixxm @David-Wobrock @jacobtylerwalls