Skip to content

Conversation

sabderemane
Copy link
Member

@sabderemane sabderemane commented Sep 13, 2023

Header tag was changed to <header> get the landmark banner for accessibility.

Note: I remove the overflow: hidden, here is why :

Without the overflow ⬇️
Capture d’écran 2023-09-13 à 22 37 16

With the overflow ⬇️
Capture d’écran 2023-09-13 à 22 43 38

@sabderemane sabderemane requested a review from a team September 13, 2023 19:32
@smithdc1 smithdc1 added the selenium Apply to have Selenium tests run on a PR label Sep 13, 2023
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @sabderemane! If we remove the overflow then I think we can go one step further and also remove:

#container > div {
flex-shrink: 0;
}

As far as I can see this only applied to the header div.

@felixxm
Copy link
Member

felixxm commented Sep 14, 2023

@sabderemane Thanks 👍 Can you add a small test and release note?

@sabderemane
Copy link
Member Author

Sure @felixxm, I'll add both :)

@sabderemane sabderemane requested a review from felixxm September 14, 2023 23:01
@sabderemane sabderemane force-pushed the ticket_34832 branch 3 times, most recently from ebb033a to 17c6e52 Compare September 14, 2023 23:42
@sabderemane sabderemane removed the request for review from felixxm September 15, 2023 00:00
@sabderemane sabderemane marked this pull request as draft September 15, 2023 00:01
@felixxm felixxm changed the title Refs #34832 -- Change header HTML tag for accessibility Fixed #34832 -- Made admin's header content render in <header> tag. Sep 15, 2023
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabderemane Thanks 👍

I changed to a small non-selenium test.

@felixxm felixxm marked this pull request as ready for review September 15, 2023 03:35
Header tag was changed to <header> get the landmark banner for
accessibility.
@felixxm felixxm merged commit 814e7bc into django:main Sep 15, 2023
@sabderemane sabderemane deleted the ticket_34832 branch September 15, 2023 12:10
@felixxm felixxm temporarily deployed to schedules September 16, 2023 02:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selenium Apply to have Selenium tests run on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants