-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Fixed #34832 -- Made admin's header content render in <header> tag. #17258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bce7414
to
3b32a32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @sabderemane! If we remove the overflow then I think we can go one step further and also remove:
django/django/contrib/admin/static/admin/css/base.css
Lines 837 to 839 in f92e68c
#container > div { | |
flex-shrink: 0; | |
} |
As far as I can see this only applied to the header div.
@sabderemane Thanks 👍 Can you add a small test and release note? |
Sure @felixxm, I'll add both :) |
3b32a32
to
d03fcb4
Compare
ebb033a
to
17c6e52
Compare
17c6e52
to
9d6006f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabderemane Thanks 👍
I changed to a small non-selenium test.
Header tag was changed to <header> get the landmark banner for accessibility.
9d6006f
to
814e7bc
Compare
Header tag was changed to
<header>
get the landmark banner for accessibility.Note: I remove the
overflow: hidden
, here is why :Without the overflow ⬇️

With the overflow ⬇️
