Fixed #14087 -- find management commands in namespace packages #178

bhuztez · June 28, 2012

improve joh's and nfg's patches, find management commands in namespace packages only. packages imported by pep-302 importers should be in another patch.

https://code.djangoproject.com/ticket/14087

manfre · December 10, 2012

Why was this test converted to an identity insert? This bypasses SQLCompilers and any backend that needs to do special handling for identity inserts.

Thanks, fixed in 0cdfa76

dreynolds · April 19, 2013

This certainly works for me. Anything we can do to get it committed?

Natim · June 05, 2013

Well it works !

rochacbruno · July 11, 2013

Yes it works! Why isn't accepted yet?

Natim · July 11, 2013

Please merge. For now to each deployement I have to patch manually in order to see namespace commands.

apollo13 · August 26, 2013

As I noted on the previous PR (#866) I'd like to see:

Support for PEP 420
Check other locations in Django for the same issues (app template loaders etc come to mind)

timgraham · September 18, 2013

Closing this for now in light of @apollo13's comments.

Natim · September 19, 2013

So it is not fixed !
The code of all the PR is not enough to explain the solution and the problem ?

rochacbruno · September 19, 2013

Why is it not fixed? I testes this PR, it works well and solves the problem, more than one year, what would be the solution?

Natim · September 19, 2013

What else do you mean by support for PEP#420 ?
There is no other location bug so far. We are using this fix for a year without problem.

apollo13 · September 19, 2013

@Natim PEP420 gives python 3 implicit namespaces, so this PR should at least have a test to test that those new namespaces work too. Even though the current patch solves your issue, as a core dev our goal is to improve Django as a whole, which for me in that case means to include support for all (common) namespace solutions out there.

@rochacbruno A statement or rather tested support for PEP 420.

As a sidenote: this PR currently includes 12 commits, most of them unrelated to this PR, so that's not really nice to review either… Also this PR has no two pretty much identical codepaths in django/core/management/init.py, which should at least be factored out into a helper function.

rochacbruno · September 19, 2013

So all we need is to isolate the code related to the namespace issue, create the test for PEP 420 and send another PR?

apollo13 · September 19, 2013

Kind of, at least then the PR would be in a reviewable shape.

bhuztez · September 19, 2013

@apollo13 just one commit, 82f5a71. I guess it is because master has changed after this PR was made.

Django try very hard NOT to import any module when finding management commands, but Django do import app package before finding templates, static files, fixture. So other parts do not have to be patched.

bhuztez referenced this pull request April 19, 2013
Closed
Fix management load #866

rochacbruno referenced this pull request in opps/opps July 17, 2013
Open
[opps-feedcrawler] Management command is not recognized by django manage.py #160

timgraham closed this September 18, 2013

orblivion	`Typeo in ValuesQuerySet._as_sql docstring`	`0ff1d4f`
ptone	`Merge pull request #569 from orblivion/master` … Fixed typo in ValuesQuerySet._as_sql docstring	`6d27547`
claudep	`Fixed #19416 -- Fixed multi-line commands in initial SQL files` … Thanks Aymeric Augustin for detecting this regression.	`5fa5621`
sebasmagri	`Fixed #19318 -- Ensured that the admin's SimpleListFilter options can…` … … be displayed as selected even if the lookup's first element is not a string.	`88e1715`
ramiro	`Fixed #18697 -- Made values accepted for two customizable admin templ…` … …ates consistent. Thanks and at cloverfastfood dot com for the report.	`b64d304`
andrewgodwin	`Merge pull request #573 from tominsam/master` … Fixed #19070: urlize template filter raises exception in some cases	`501c7a2`
claudep	`Fixed #19378 -- Ensured get_success_url returns a non-lazy URL`	`795ac7d`
jphalip	`Fixed the admin_filters tests for Postgres.`	`c196e01`
akaariai	`Fixed #19391 -- Oracle specific failure in tests` … The failure was caused by using None as a choice for a CharField. To avoid Oracle's "" <-> NULL handling the field type was changed to IntegerField.	`632cf32`
ramiro	`Minor idiomatic and docstring edits in ar localflavor.`	`45f00db`
evildmp	`Amended explanation of LOCALE_PATHS setting.` … Thanks Daniele Procida for the patch.	`37abad7`
bhuztez	`Fixed #14087 -- find management commands in namespace packages`	`82f5a71`


ptone	`Merge pull request #569 from orblivion/master` … Fixed typo in ValuesQuerySet._as_sql docstring	`6d27547`
claudep	`Fixed #19416 -- Fixed multi-line commands in initial SQL files` … Thanks Aymeric Augustin for detecting this regression.	`5fa5621`
sebasmagri	`Fixed #19318 -- Ensured that the admin's SimpleListFilter options can…` … … be displayed as selected even if the lookup's first element is not a string.	`88e1715`


ramiro	`Fixed #18697 -- Made values accepted for two customizable admin templ…` … …ates consistent. Thanks and at cloverfastfood dot com for the report.	`b64d304`
andrewgodwin	`Merge pull request #573 from tominsam/master` … Fixed #19070: urlize template filter raises exception in some cases	`501c7a2`
claudep	`Fixed #19378 -- Ensured get_success_url returns a non-lazy URL`	`795ac7d`
jphalip	`Fixed the admin_filters tests for Postgres.`	`c196e01`
akaariai	`Fixed #19391 -- Oracle specific failure in tests` … The failure was caused by using None as a choice for a CharField. To avoid Oracle's "" <-> NULL handling the field type was changed to IntegerField.	`632cf32`
ramiro	`Minor idiomatic and docstring edits in ar localflavor.`	`45f00db`
evildmp	`Amended explanation of LOCALE_PATHS setting.` … Thanks Daniele Procida for the patch.	`37abad7`

@@ -9,7 +9,7 @@
          from django.db import models
          from django.core.exceptions import ImproperlyConfigured, ValidationError
         -from django.utils.encoding import smart_text
         +from django.utils.encoding import smart_text, force_text
          from django.utils.translation import ugettext_lazy as _
          from django.utils import timezone
          from django.contrib.admin.util import (get_model_from_relation,
@@ -102,7 +102,7 @@ def choices(self, cl):
                  }
                  for lookup, title in self.lookup_choices:
                      yield {
         -                'selected': self.value() == lookup,
         +                'selected': self.value() == force_text(lookup),
                          'query_string': cl.get_query_string({
                              self.parameter_name: lookup,
                          }, []),

@@ -391,9 +391,9 @@ def index(self, request, extra_context=None):
                      'app_list': app_list,
                  }
                  context.update(extra_context or {})
         -        return TemplateResponse(request, [
         -            self.index_template or 'admin/index.html',
         -        ], context, current_app=self.name)
         +        return TemplateResponse(request, self.index_template or
         +                                'admin/index.html', context,
         +                                current_app=self.name)
              def app_index(self, request, app_label, extra_context=None):
                  user = request.user

public django/django

HTTPS clone URL

Subversion checkout URL

Fixed #14087 -- find management commands in namespace packages #178

Milestone

Assignee

Notifications

16 participants

People participating in this pull request

Fix management load #866

[opps-feedcrawler] Management command is not recognized by django manage.py #160

...	...	@@ -0,0 +1 @@
	1	+import os.path, site; site.addsitedir(os.path.dirname(__file__))