Skip to content

Fixed #14087 -- find management commands in namespace packages #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Fixed #14087 -- find management commands in namespace packages #178

wants to merge 12 commits into from

Conversation

bhuztez
Copy link

@bhuztez bhuztez commented Jun 28, 2012

improve joh's and nfg's patches, find management commands in namespace packages only. packages imported by pep-302 importers should be in another patch.

https://code.djangoproject.com/ticket/14087

orblivion and others added 12 commits December 1, 2012 18:55
@orblivion
Typeo in ValuesQuerySet._as_sql docstring
0ff1d4f
@ptone
Merge pull request #569 from orblivion/master
6d27547 
Fixed typo in ValuesQuerySet._as_sql docstring
@claudep
Fixed #19416 -- Fixed multi-line commands in initial SQL files
5fa5621 
Thanks Aymeric Augustin for detecting this regression.
@sebasmagri @jphalip
Fixed #19318 -- Ensured that the admin's SimpleListFilter options can…
88e1715 
… be displayed as selected even if the lookup's first element is not a string.
@ramiro
Fixed #18697 -- Made values accepted for two customizable admin templ…
b64d304 
…ates consistent.

Thanks and at cloverfastfood dot com for the report.
@andrewgodwin
Merge pull request #573 from tominsam/master
501c7a2 
Fixed #19070: urlize template filter raises exception in some cases
@claudep
Fixed #19378 -- Ensured get_success_url returns a non-lazy URL
795ac7d
@jphalip
Fixed the admin_filters tests for Postgres.
c196e01
@akaariai
Fixed #19391 -- Oracle specific failure in tests
632cf32 
The failure was caused by using None as a choice for a CharField. To
avoid Oracle's "" <-> NULL handling the field type was changed to
IntegerField.
@ramiro
Minor idiomatic and docstring edits in ar localflavor.
45f00db
@evildmp @ramiro
Amended explanation of LOCALE_PATHS setting.
37abad7 
Thanks Daniele Procida for the patch.
@bhuztez
Fixed #14087 -- find management commands in namespace packages
82f5a71
@dreynolds
Copy link

This certainly works for me. Anything we can do to get it committed?

@bhuztez bhuztez mentioned this pull request Apr 20, 2013
Closed
@Natim
Copy link

Natim commented Jun 5, 2013

Well it works !

@rochacbruno
Copy link

Yes it works! Why isn't accepted yet?

@Natim
Copy link

Natim commented Jul 12, 2013

Please merge. For now to each deployement I have to patch manually in order to see namespace commands.

@rochacbruno rochacbruno mentioned this pull request Jul 17, 2013
Open
@apollo13
Copy link
Member

As I noted on the previous PR (#866) I'd like to see:

  • Support for PEP 420
  • Check other locations in Django for the same issues (app template loaders etc come to mind)

@timgraham
Copy link
Member

Closing this for now in light of @apollo13's comments.

@timgraham timgraham closed this Sep 18, 2013
@Natim
Copy link

Natim commented Sep 19, 2013

So it is not fixed !
The code of all the PR is not enough to explain the solution and the problem ?

@rochacbruno
Copy link

Why is it not fixed? I testes this PR, it works well and solves the problem, more than one year, what would be the solution?

@Natim
Copy link

Natim commented Sep 19, 2013

What else do you mean by support for PEP#420 ?
There is no other location bug so far. We are using this fix for a year without problem.

@apollo13
Copy link
Member

@Natim PEP420 gives python 3 implicit namespaces, so this PR should at least have a test to test that those new namespaces work too. Even though the current patch solves your issue, as a core dev our goal is to improve Django as a whole, which for me in that case means to include support for all (common) namespace solutions out there.

@rochacbruno A statement or rather tested support for PEP 420.

As a sidenote: this PR currently includes 12 commits, most of them unrelated to this PR, so that's not really nice to review either… Also this PR has no two pretty much identical codepaths in django/core/management/init.py, which should at least be factored out into a helper function.

@rochacbruno
Copy link

So all we need is to isolate the code related to the namespace issue, create the test for PEP 420 and send another PR?

@apollo13
Copy link
Member

Kind of, at least then the PR would be in a reviewable shape.

@bhuztez
Copy link
Author

bhuztez commented Sep 19, 2013

@apollo13 just one commit, 82f5a71. I guess it is because master has changed after this PR was made.

Django try very hard NOT to import any module when finding management commands, but Django do import app package before finding templates, static files, fixture. So other parts do not have to be patched.

sztrovacsek pushed a commit to sztrovacsek/django that referenced this pull request Mar 7, 2015
@evildmp
Merge pull request django#178 from qba73/qba73
b2aeafd 
Update attendees_and_learners.rst
nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016
@bmispelon
Merge pull request django#178 from bjacobel/master
ff1be22 
Fix a 404 link on documentation index page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.