improve joh's and nfg's patches, find management commands in namespace packages only. packages imported by pep-302 importers should be in another patch.
Typeo in ValuesQuerySet._as_sql docstring
Merge pull request #569 from orblivion/master
Fixed typo in ValuesQuerySet._as_sql docstring
Fixed #19416 -- Fixed multi-line commands in initial SQL files
Thanks Aymeric Augustin for detecting this regression.
Fixed #19318 -- Ensured that the admin's SimpleListFilter options can…
… be displayed as selected even if the lookup's first element is not a string.
Fixed #18697 -- Made values accepted for two customizable admin templ…
Thanks and at cloverfastfood dot com for the report.
Merge pull request #573 from tominsam/master
Fixed #19070: urlize template filter raises exception in some cases
Fixed #19378 -- Ensured get_success_url returns a non-lazy URL
Fixed the admin_filters tests for Postgres.
Fixed #19391 -- Oracle specific failure in tests
The failure was caused by using None as a choice for a CharField. To
avoid Oracle's "" <-> NULL handling the field type was changed to
Minor idiomatic and docstring edits in ar localflavor.
Amended explanation of LOCALE_PATHS setting.
Thanks Daniele Procida for the patch.
Fixed #14087 -- find management commands in namespace packages
Why was this test converted to an identity insert? This bypasses SQLCompilers and any backend that needs to do special handling for identity inserts.
Thanks, fixed in 0cdfa76
This certainly works for me. Anything we can do to get it committed?
Well it works !
Yes it works! Why isn't accepted yet?
Please merge. For now to each deployement I have to patch manually in order to see namespace commands.
As I noted on the previous PR (#866) I'd like to see:
Closing this for now in light of @apollo13's comments.
So it is not fixed !
The code of all the PR is not enough to explain the solution and the problem ?
Why is it not fixed? I testes this PR, it works well and solves the problem, more than one year, what would be the solution?
What else do you mean by support for PEP#420 ?
There is no other location bug so far. We are using this fix for a year without problem.
@Natim PEP420 gives python 3 implicit namespaces, so this PR should at least have a test to test that those new namespaces work too. Even though the current patch solves your issue, as a core dev our goal is to improve Django as a whole, which for me in that case means to include support for all (common) namespace solutions out there.
@rochacbruno A statement or rather tested support for PEP 420.
As a sidenote: this PR currently includes 12 commits, most of them unrelated to this PR, so that's not really nice to review either… Also this PR has no two pretty much identical codepaths in django/core/management/init.py, which should at least be factored out into a helper function.
So all we need is to isolate the code related to the namespace issue, create the test for PEP 420 and send another PR?
Kind of, at least then the PR would be in a reviewable shape.
@apollo13 just one commit, 82f5a71. I guess it is because master has changed after this PR was made.
Django try very hard NOT to import any module when finding management commands, but Django do import app package before finding templates, static files, fixture. So other parts do not have to be patched.