Skip to content

Conversation

daveisfera
Copy link

@daveisfera daveisfera commented Jul 2, 2024

Trac ticket number

N/A

Branch description

Raising Http404 logs the response as if HttpResponseNotFound was returned, but raising BadRequest includes exc_info and that differs from a response of HttpResponseBadRequest and looks like something exceptional went wrong in the logs, so being able to disable this behavior using NO_LOG_EXCEPTION_IN_RESPONSE allows the raise handling to be a first class citizen like return handling

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@jacobtylerwalls
Copy link
Member

Hi @daveisfera 👋

The first stop for feature requests is the Django forum, in the Internals category. If there's support for your feature request on the forum discussion, you can open a ticket and proceed with a PR then. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants