Refs #10941 -- Added tests for querystring template tag. #18487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nessita
force-pushed
the
refs-10941-querystring-extra-tests
branch
from
0db2b42 to
946cefc
Compare
nessita
changed the title
g-nie
reviewed
Aug 18, 2024
nessita
force-pushed
the
refs-10941-querystring-extra-tests
branch
2 times, most recently
from
4d207d2 to
b518f43
Compare
|
I split the diff in two commits, the first one introduces the helper and does the refactor, the second adds two new tests. |
sarahboyce
approved these changes
Aug 20, 2024
nessita
force-pushed
the
refs-10941-querystring-extra-tests
branch
from
b518f43 to
69b1623
Compare
mahfuztbt
approved these changes
Aug 22, 2024
nessita
force-pushed
the
refs-10941-querystring-extra-tests
branch
from
69b1623 to
d6ab249
Compare
|
Hey, how is this looking? I'd like to finish off #18368 once this is merged ✨ |
nessita
force-pushed
the
refs-10941-querystring-extra-tests
branch
from
d6ab249 to
ecd8df1
Compare
…g template tag. Thank you Sarah Boyce for the review and suggestions.
These extra tests assert over the handling of empty params (None, empty dict, empty QueryDict), and also for dicts having non-string keys.
nessita
force-pushed
the
refs-10941-querystring-extra-tests
branch
from
ecd8df1 to
ccf0b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-10941
Branch description
This branch adds extra tests for the
querystringtemplate tag, in preparation for merging PR #18368.This branch also implements a small test refactoring to avoid duplication, inspired by utils' tests for safestring
assertRenderEqual.Checklist
mainbranch.