Refs #28586 -- Split descriptor from GenericForeignKey. #19381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
commented
Apr 14, 2025
There was a problem hiding this comment.
PR #17886 attempts to remove this check function, though I haven't managed to get that into a mergeable state yet.
6 tasks
adamchainz
force-pushed
the
ticket_28586_gfk_descriptor
branch
from
0eaca3b to
28b6b1f
Compare
adamchainz
force-pushed
the
ticket_28586_gfk_descriptor
branch
from
28b6b1f to
7a61735
Compare
adamchainz
force-pushed
the
ticket_28586_gfk_descriptor
branch
4 times, most recently
from
600a157 to
f5d8c48
Compare
adamchainz
force-pushed
the
ticket_28586_gfk_descriptor
branch
3 times, most recently
from
5af844a to
bc2e3f2
Compare
This makes GenericForeignKey more similar to other fields which act as descriptors, preparing it to add “fetcher protocol” support in a clear and consistent way.
jacobtylerwalls
force-pushed
the
ticket_28586_gfk_descriptor
branch
from
bc2e3f2 to
d79d1f7
Compare
jacobtylerwalls
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-28586
Branch description
To support field fetching modes for
GenericForeignKey, it needs to conform to a new "fetcher protocol", which includes having afieldattribute that points from the "fetcher" to the actual field.The core related fields, like
ForeignKey, all use descriptors with afieldattribute. These descriptors then act as their "fetcher" class.GenericForeignKeyhas always been a bit odd because it does not have a separate descriptor class. This PR removes that oddity by adding such a class and moving the appropriate methods there.This change follows ticket-35224, which made
GenericForeignKeyan actual field class.Checklist
mainbranch.