Skip to content

Conversation

Antoliny0919
Copy link
Contributor

Trac ticket number

ticket-36558

Branch description

Fixed the pagination "show all" link so it no longer inherits the pagination button style.

Before

show_all_before

After

show_all_after

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@sarahboyce
Copy link
Contributor

Thank you @Antoliny0919
I pushed up a tweak to try and simplify the css in general around the .showall class
Can you add a screenshot test to cover pagination as I see we don't have any screenshots with pagination

@sarahboyce sarahboyce added the selenium Apply to have Selenium tests run on a PR label Aug 20, 2025
@sarahboyce
Copy link
Contributor

Thank you for the test, it's identified a different regression with 3f59711 for the mobile view

On 5.2, this gives me:
image

But on main:
image

I believe there's too much spacing on mobile.
Can you resolve this with a separate commit, something like: Refs #36366 -- Fixed admin pagination mobile layout.

@Antoliny0919
Copy link
Contributor Author

Antoliny0919 commented Aug 21, 2025

Thank you for the test, it's identified a different regression with 3f59711 for the mobile view
I believe there's too much spacing on mobile. Can you resolve this with a separate commit, something like: Refs #36366 -- Fixed admin pagination mobile layout.

Good point, thank you Sarah. I had a feeling something looked a bit off when I checked the mobile sized screenshot.
It turns out the original layout was broken 🥲

I believe there's too much spacing on mobile. Can you resolve this with a separate commit, something like: Refs #36366 -- Fixed admin pagination mobile layout.

Of course! I’ll submit a PR.

#19759

Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sarahboyce sarahboyce merged commit 0b2493a into django:main Aug 22, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

screenshots 🖼️ selenium Apply to have Selenium tests run on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants