Skip to content

Conversation

johannes-gehrs
Copy link
Contributor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To say "In some cases" without giving an example leaves me wondering why I'd want to use TemplateResponse over HttpResponse. I guess I could check the documentation about it, but I'd either given an example here or just say something like "If you wish to use TemplateResponse ..."

@timgraham
Copy link
Member

Thanks for the contribution. I've left some suggestions above. Please also remove trailing whitespace from your patch (if possible, configure your editor to do that when saving a file if you wish).

@johannes-gehrs
Copy link
Contributor Author

Thanks for your feedback.

I have accidentally messed up the history of this pull request in git.

However, I have now removed trailing whitespace and I have modified the commit as per your suggestion. I think the information is now a little more concise and clear.

@timgraham
Copy link
Member

merged in f685f94. For future reference, please note our commit message guidelines. Thanks!

@timgraham timgraham closed this Dec 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants