Fixed #22738 -- made finer distinctions for when Boolean is not detected on Oracle #3283
+40
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
django/db/backends/__init__.py
Outdated
There was a problem hiding this comment.
Better make it a method instead of a lambda. If I'm not mistaken lambda expression assignment is also a flake8 violation.
There was a problem hiding this comment.
the lambdas were missing a self argument, other than that I like them better for a constant method like this. Flake8 said nothing :)
There was a problem hiding this comment.
On second thought, you're right, I'm defining an interface here.
|
@claudep @charettes -- is this going too far for supporting the buggy Oracle versions? |
|
Since this is API is not publicly exposed nor documented I don't think we should worry too much about it. I believe we should go as far as needed to make the test pass on Oracle instead of skipping it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first served as a PR for two purposes: