Fixed #24469 -- Fixed escaping of forms, fields, and media in non-Django templates. #4291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzS
force-pushed
the
ticket_24469
branch
2 times, most recently
from
c57317e to
86aae69
Compare
There was a problem hiding this comment.
It doesn't seem the output should be too lengthy, could we use assertHTMLEqual() instead?
There was a problem hiding this comment.
Yeah, that's probably more concise.
MoritzS
changed the title
There was a problem hiding this comment.
since templates are identical, would it be worth creating them from a string in the test rather than loading them from the filesystem?
There was a problem hiding this comment.
I'd say it's besser to keep them as files, because right now they just happen to be identical.
When django someday supports a new Template backend that doesn't use {{ var }} syntax it's easier to separate the backends with different directories.
timgraham
changed the title
|
buildbot, add to whitelist. |
|
merged in 6bff343, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://code.djangoproject.com/ticket/24469 for more information