-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Fixed #25379 -- Removed obsolete information from GeoDjango tutorial. #5265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It should be done automatically as of Django 1.8 (bac7664). Did you test it? |
I did try on master (0cc0e67), and it does not add the |
Looking at the implementation, it wouldn't appear in |
I've verified and I'll amend my commit |
docs/ref/contrib/gis/tutorial.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django 1.9 drops support for PostgreSQL 9.0, so this is obsolete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which case, I'm not sure the special mention about how to create a database in PostgreSQL is needed (given the other databases aren't mentioned). What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I've removed the whole sentence
While we're here, shuold we suggest |
I don't know anything about that (don't use OSX), but I think that section is likely outdated so if you think there are new best practices, I'm sure an update to that section would be welcome. Seems like a separate ticket though. |
merged in dfced09, thanks! |
ref https://code.djangoproject.com/ticket/25379#ticket
Update GeoDjango tutorial to Postgres 9.1+ and CreateExtension
The GeoDjango tutorial (https://docs.djangoproject.com/en/1.8/ref/contrib/gis/tutorial/) still instructs to create a db using the spatial template.
Since PostgresSQL 9.1, the preferred way is to use the
postgis
extension instead.This brings up another issue: should
makemigrations
automatically add aCreateExtension
operation? Is that even doable?For now I've simply documented it, but it would be very handy to have it automatically.