Fixed #25867 -- Fixed a system check crash with nested ArrayFields. #5771
Conversation
There was a problem hiding this comment.
Is there a reason not to use the property decorator syntax?
There was a problem hiding this comment.
Could do. I usually avoid it in my own code because while the super() getter is easily accessible with super().attribute you to have deal with the property internals (fset) to access the setter.
timgraham
changed the title
tests/postgres_tests/test_array.py
Outdated
There was a problem hiding this comment.
Instead of describing how things failed at one point in time, I think it's more helpful to state the expected behavior, e.g. "Nested ArrayFields are permitted." It would also be helpful to include a comment about what "postgres.E001" is.
There was a problem hiding this comment.
Alright, this was mostly a copy of test_field_checks above with a nested array field instead.
charettes
force-pushed
the
ticket-25867
branch
from
7368d2f to
9f5dfe6
Compare
tests/postgres_tests/test_array.py
Outdated
There was a problem hiding this comment.
@timgraham does this comment makes sense to you?
There was a problem hiding this comment.
I guess I would say something like "The inner CharField is missing a max_length."
Thanks to Jean Gourds for the report, Tim and Claude for the review.
charettes
force-pushed
the
ticket-25867
branch
from
9f5dfe6 to
59b57e6
Compare
Thanks to Jean Gourds for the report.