Skip to content

Conversation

tubaman
Copy link
Contributor

@tubaman tubaman commented Feb 14, 2016

polls.migrations should be included in setup.py packages. Otherwise the
migrations won't be included in the tarball.

@timgraham timgraham changed the title Include polls.migrations in setup.py packages Fixed #26221-- Included polls.migrations in setup.py packages Feb 15, 2016
@timgraham
Copy link
Member

Checking Django itself and a few third-party apps (django-hosts, django-debug-toolbar), they use setuptools.find_packages() (possibly with some excludes). Maybe that's a better pattern to use?

Use find_packages to include polls.migrations in setup.py packages.
Otherwise the migrations won't be included in the tarball.
@tubaman tubaman force-pushed the include_migrations_in_setup_py branch from 638a5d4 to 8b9e1b7 Compare February 15, 2016 21:21
@tubaman
Copy link
Contributor Author

tubaman commented Feb 15, 2016

Yup, makes sense... PR has been modified to use find_packages.

@timgraham
Copy link
Member

merged in 11af73e, thanks!

@timgraham timgraham closed this Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants