Skip to content

Conversation

sir-sigurd
Copy link
Member

https://code.djangoproject.com/ticket/17448
https://code.djangoproject.com/ticket/28632

@claudep, I'm not sure if I should restore possibility to select geometry fields without select formatting on Postgres, because it's slower than selecting as bytea by 10%.

@sir-sigurd sir-sigurd force-pushed the geo-raw-query branch 2 times, most recently from d204678 to 3683192 Compare November 1, 2017 14:12
@claudep
Copy link
Member

claudep commented Nov 1, 2017

I'm fine with that approach. However, if there is a small backwards incompatibility, I would still mention it in the release notes.

@timgraham
Copy link
Member

I edited the docs a bit based on my understanding of the issue. Please check that it's accurate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timgraham, I'm not sure if there is sense to mention connection.ops.select here since it wasn’t doc'd anyhow so I don't think someone used it. Perhaps we should say without any condition: "your raw SQL queries need to be updated".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've amended it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timgraham, it was changed on MySQL and SpatiaLite too, but again, I don't think we need this "if" since I'd like to encourage people to use connection.ops.select so things will be more robust to changes in Django.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've amended it again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now.

@timgraham timgraham merged commit 8869142 into django:master Nov 4, 2017
@sir-sigurd sir-sigurd deleted the geo-raw-query branch November 6, 2017 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants