-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message by providing the file where the error occurred if it is not an inlined source #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Mar 12, 2024
GuillaumeGomez
force-pushed
the
improve-error
branch
13 times, most recently
from
March 12, 2024 13:29
a85b30a
to
7ae98b4
Compare
Finally made tests work on CI. \o/ I added a ui test as well (took me more time than I expected...). |
GuillaumeGomez
force-pushed
the
improve-error
branch
2 times, most recently
from
March 18, 2024 14:48
e726b14
to
d353041
Compare
Updated! |
djc
reviewed
Mar 19, 2024
GuillaumeGomez
force-pushed
the
improve-error
branch
from
March 29, 2024 17:49
d353041
to
a22a776
Compare
Rebased on #994. |
djc
reviewed
Apr 5, 2024
…if it is not an inlined source
GuillaumeGomez
force-pushed
the
improve-error
branch
from
April 5, 2024 09:35
a22a776
to
2d1e0ec
Compare
djc
reviewed
Apr 5, 2024
djc
reviewed
Apr 5, 2024
djc
approved these changes
Apr 5, 2024
Thanks for the reviews! Merging then. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have templates included in templates, the errors become quite difficult to understand as we don't know which file is triggering it. With this change, it adds the path of the file where the error is located:
Making my life and very likely everyone else's better. :)
Sadly, I can't enforce it with
trybuild
as it only allows to have inline tests (because the folder where the ui tests are run is different and I couldn't find a way to do it...).