Allow to have access to imports in block calls #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
commented
Mar 12, 2024
| @@ -60,7 +60,7 @@ impl<'a> Generator<'a> { | |||
| } | |||
|
|
|||
| // Takes a Context and generates the relevant implementations. | |||
| pub(crate) fn build(mut self, ctx: &'a Context<'_>) -> Result<String, CompileError> { | |||
| pub(crate) fn build(mut self, ctx: &Context<'a>) -> Result<String, CompileError> { | |||
There was a problem hiding this comment.
I relaxed the lifetime rules as they were too strict for my use case. Like this we can pass a temporary Context as long as it points to the same data.
GuillaumeGomez
force-pushed
the
block-import-access
branch
2 times, most recently
from
77d3805
to
ef2dd67
Compare
|
Solved clippy lints as well. Hopefully with this one, I'll have everything I need to end the switch from |
GuillaumeGomez
force-pushed
the
block-import-access
branch
from
ef2dd67
to
1a4b7f4
Compare
|
As discussed in #989, variables defined outside a block should not be accessible inside a block. |
|
Ah I need #986 to be merged first for this ui test to work. ^^' |
GuillaumeGomez
force-pushed
the
block-import-access
branch
from
1a4b7f4
to
77a570e
Compare
|
Rebased. It's now ready for review! |
GuillaumeGomez
force-pushed
the
block-import-access
branch
from
77a570e
to
2dfff27
Compare
djc
approved these changes
Apr 25, 2024
GuillaumeGomez
force-pushed
the
block-import-access
branch
from
2dfff27
to
e4040a4
Compare
|
Since you approved, merging. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989.