Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aad auth update #34

Merged
merged 16 commits into from
Dec 21, 2020
Merged

Feature/aad auth update #34

merged 16 commits into from
Dec 21, 2020

Conversation

djpugh
Copy link
Owner

@djpugh djpugh commented Dec 15, 2020

Add ``fastapi_aad_auth` as authentication base and fixing any associated issues

This has changed some of the configuration options and behaviours

@todo
Copy link

todo bot commented Dec 15, 2020

check if this has been updated

# TODO: check if this has been updated
def get_swagger_ui_html(*args, **kwargs) -> HTMLResponse:
response = _get_swagger_ui_html(*args, **kwargs)
return wrap_response(response)


This comment was generated by todo based on a TODO comment in d8f747a in #34. cc @djpugh.

@todo
Copy link

todo bot commented Dec 15, 2020

add handler for non interactive auth error

# TODO: add handler for non interactive auth error
def _set_error_handlers(self, app):
error_template_path = Path(self.config.login_ui.error_template_file)
error_templates = Jinja2Templates(directory=str(error_template_path.parent))
if self.config.login_ui.app_name:


This comment was generated by todo based on a TODO comment in 7277593 in #34. cc @djpugh.

@djpugh djpugh removed the automerge label Dec 15, 2020
@todo
Copy link

todo bot commented Dec 15, 2020

Check How this works with state/user

# TODO: Check How this works with state/user
class APIUser(BaseModel):
permissions: List[str] = []


This comment was generated by todo based on a TODO comment in ce8cb4a in #34. cc @djpugh.

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@djpugh djpugh merged commit 78c7f7f into main Dec 21, 2020
@djpugh djpugh deleted the feature/aad-auth-update branch December 21, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant