Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Conda/bioconda release of CMash #16

Open
dkoslicki opened this issue Feb 6, 2020 · 3 comments · Fixed by bioconda/bioconda-recipes#20701
Open

Make a Conda/bioconda release of CMash #16

dkoslicki opened this issue Feb 6, 2020 · 3 comments · Fixed by bioconda/bioconda-recipes#20701

Comments

@dkoslicki
Copy link
Owner

This will also serve to assist with the installation of Metalign.

@luizirber
Copy link

cmash is now in bioconda, since bioconda/bioconda-recipes#20701 was merged

@dkoslicki
Copy link
Owner Author

@luizirber You’ll have to educate me about how this was accomplished. In particular, is this bioconda version pegged to a release of CMash, or just generally tracking CMash as updates to master happening? Eg. How to update the bioconda release? Etc.

I imagine a brief face-to-face/teleconference would help with this, as getting CMash on bioconda has been a big goal, but you’ve appeared to make it seem rather trivial to do, and I’d love to be educated about how you accomplished it.

@luizirber
Copy link

@luizirber You’ll have to educate me about how this was accomplished. In particular, is this bioconda version pegged to a release of CMash, or just generally tracking CMash as updates to master happening? Eg. How to update the bioconda release? Etc.

Since the github release (v0.4.0) was newer than the one in PyPI I used that as a base, So, any time you tag a new release Bioconda will detect the new release and create a new PR (here is an example for sourmash, but we list the PyPI URL there instead). Since I listed you as a recipe maintainer in CMash, you will get a github notification, and when tests pass you can merge it (if you're a bioconda team member) or ask for someone to merge it. If tests are not passing, you can commit new changes to the PR to fix problems (missing dependencies, for example)

I also had to package a PyPI dependency missing in bioconda/conda-forge (Hydra), so now I'm a package maintainer in https://github.com/conda-forge/hydra-feedstock. I don't foresee many issues arising (since hydra is pretty stable and probably won't have new versions), but if can also join as a recipe maintainer if you want (I don't even use hydra 🤣)

I imagine a brief face-to-face/teleconference would help with this, as getting CMash on bioconda has been a big goal, but you’ve appeared to make it seem rather trivial to do, and I’d love to be educated about how you accomplished it.

If you have any other questions we can go in more detail, we can try to schedule something (depending on your availability =])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants