cppmangle: Add more tests, fix double 'N' #10053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a regression spotted by SSoulaimane. Also add the scoped Namespace tests as non-scoped tests.
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10053" |
thewilsonator
approved these changes
Jun 18, 2019
|
@MartinNowak : As mentioned on Slack (https://dlang.slack.com/archives/C4DN1H6LA/p1560818579001800) this and the previous PR needs to go in otherwise |
Geod24
commented
Jun 18, 2019
| { | ||
| auto sl = this.buf.peekSlice(); | ||
| assert(sl.length == 0 || haveNE || s.namespace is null || sl != "_ZN"); | ||
| } |
There was a problem hiding this comment.
It won't cause any bug but I think this assert should be more structured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10021 (comment)
Also copied all the
extern(C++, Namespace)tests asextern(C++, "Namespace")since it seems #10031 is not getting in any time soon.