Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dmd-cxx] fix Issue 20113 - Cannot find source code for runtime library file 'object.d' when the path contains '~' #10309

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Aug 15, 2019

Backport of #10284.

…ry file 'object.d' when the path contains '~'
@ibuclaw ibuclaw added GDC Gnu D Compiler C++ Port labels Aug 15, 2019
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
20113 normal Cannot find source code for runtime library file 'object.d' when the path contains '~'

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "dmd-cxx + dmd#10309"

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 15, 2019

Should probably fix OSX builds too...

bool CTFloat::isNaN(real_t r)
{
#if __APPLE__
#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 1080
    return __inline_isnanl(r);
#else
    return __inline_isnan(r);
#endif
#elif __FreeBSD__ || __OpenBSD__
    return isnan(r);
#else
    #undef isnan
    return ::isnan(r);   <-- Error line here.
#endif
}

Apparently __APPLE__ is not a recognized macro anymore?

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 15, 2019

Apparently APPLE is not a recognized macro anymore?

Ah, no, it's not OSX, it's just clang on linux... Should be reproducible locally then.

@ibuclaw ibuclaw force-pushed the dmd-cxx-20113 branch 2 times, most recently from 969b00e to 14aeb24 Compare August 15, 2019 13:54
@ibuclaw ibuclaw merged commit b37a537 into dlang:dmd-cxx Aug 16, 2019
@ibuclaw ibuclaw deleted the dmd-cxx-20113 branch August 16, 2019 05:50
kraj pushed a commit to kraj/gcc that referenced this pull request Aug 21, 2019
d/dmd: Merge upstream dmd b37a537d3

Fixes the error: cannot find source code for runtime library file
'object.d' when the path contains '~'.

Reviewed-on: dlang/dmd#10309

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@274771 138bc75d-0d04-0410-961f-82ee72b054a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants