[dmd-cxx] expression.c: Fix wrong sizeof VectorArrayExp #11046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Expression node is smaller than VectorExp, causing valgrind to complain. ==162456== Invalid read of size 8 ==162456== at 0x6C38E9: Expression::copy() (expression.c:2046) ==162456== by 0x664547: visit (dcast.c:68) ==162456== by 0x664547: implicitCastTo(Expression*, Scope*, Type*)::ImplicitC astTo::visit(Expression*) (dcast.c:54) ==162456== by 0x66BE8A: implicitCastTo(Expression*, Scope*, Type*) (dcast.c:1 60)
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "dmd-cxx + dmd#11046" |
thewilsonator
approved these changes
Apr 19, 2020
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Apr 19, 2020
Initializes the VectorArrayExp::size field with the correct value. Fixes: PR d/94652 Reviewed-on: dlang/dmd#11046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Expression node is smaller than VectorExp, causing valgrind to complain.
==162456== Invalid read of size 8
==162456== at 0x6C38E9: Expression::copy() (expression.c:2046)
==162456== by 0x664547: visit (dcast.c:68)
==162456== by 0x664547: implicitCastTo(Expression*, Scope*, Type*)::ImplicitC
astTo::visit(Expression*) (dcast.c:54)
==162456== by 0x66BE8A: implicitCastTo(Expression*, Scope*, Type*) (dcast.c:1
60)