[dmd-cxx] Add COMPILABLE_MATH_TEST test directive to tests that import std.math #11060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "dmd-cxx + dmd#11060" |
thewilsonator
approved these changes
Apr 26, 2020
|
Merging. |
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Apr 27, 2020
Adds a new test directive COMPILABLE_MATH_TEST, and support has been added for it in gdc-convert-test so that they are skipped if phobos is not present on the target. Only change in D runtime is a small documentation fix. Reviewed-on: dlang/druntime#3067 dlang/dmd#11060 gcc/testsuite/ChangeLog: PR d/89418 * lib/gdc-utils.exp (gdc-convert-test): Add dg-skip-if for compilable tests that depend on the phobos standard library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #11056, but this is to catch targets that don't have
realsupport in std.math (e.g: PPC/PPC64 IBM long doubles).In master, either we need to remove the
static assertthat checks mant_dig. Or we add complete support for IBM long doubles. Splitting off std.math into a package may come first though...