Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jumpless signed divide by 2 #11441

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Conversation

WalterBright
Copy link
Member

Because jumpless is better.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11441"

@UplinkCoder
Copy link
Member

Seems to break unittests of mir and ocean.

@12345swordy
Copy link
Contributor

What unit test in question that this PR break @UplinkCoder?

@WalterBright
Copy link
Member Author

Found the problem, and added a test case for it so the test suite will catch it rather than buildkite.

@andralex andralex merged commit 47b7ac6 into dlang:master Jul 22, 2020
@WalterBright WalterBright deleted the jumpless-div branch July 23, 2020 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants