[dmd-cxx] fix Issue 22133 - [REG2.097] Breaking change in DotTemplateExp type semantics leading to e.g. isInputRange regression #12920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Exp type semantics leading to e.g. isInputRange regression
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "dmd-cxx + dmd#12920" |
thewilsonator
approved these changes
Jul 25, 2021
|
This found its way into dmd-cxx via #12668, which addressed many latent bugs in |
nstester
pushed a commit
to nstester/gcc
that referenced
this pull request
Jul 28, 2021
…01619) By giving dot templates a type, meant that properry resolving silently started passing for code that should never have passed. The simple fix is to provide implementations for checkType and checkValue that give an error about dot templates having neither a value nor type. Reviewed-on: dlang/dmd#12920 PR d/101619 gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd 1d8386a63.
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jul 28, 2021
…01619) By giving dot templates a type, meant that properry resolving silently started passing for code that should never have passed. The simple fix is to provide implementations for checkType and checkValue that give an error about dot templates having neither a value nor type. Reviewed-on: dlang/dmd#12920 PR d/101619 gcc/d/ChangeLog: * dmd/expression.c (DotTemplateExp::checkType): New function. (DotTemplateExp::checkValue): New function. * dmd/expression.h (class DotTemplateExp): Declare checkType and checkValue. gcc/testsuite/ChangeLog: * gdc.test/fail_compilation/fail7424b.d: Update test. * gdc.test/fail_compilation/fail7424c.d: Update test. * gdc.test/fail_compilation/fail7424d.d: Update test. * gdc.test/fail_compilation/fail7424e.d: Update test. * gdc.test/fail_compilation/fail7424f.d: Update test. * gdc.test/fail_compilation/fail7424g.d: Update test. * gdc.test/fail_compilation/fail7424h.d: Update test. * gdc.test/fail_compilation/fail7424i.d: Update test. * gdc.test/compilable/test22133.d: New test. * gdc.test/fail_compilation/fail22133.d: New test. (cherry picked from commit 3e21361)
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jul 28, 2021
…01619) By giving dot templates a type, meant that properry resolving silently started passing for code that should never have passed. The simple fix is to provide implementations for checkType and checkValue that give an error about dot templates having neither a value nor type. Reviewed-on: dlang/dmd#12920 PR d/101619 gcc/d/ChangeLog: * dmd/expression.c (DotTemplateExp::checkType): New function. (DotTemplateExp::checkValue): New function. * dmd/expression.h (class DotTemplateExp): Declare checkType and checkValue. gcc/testsuite/ChangeLog: * gdc.test/fail_compilation/fail7424b.d: Update test. * gdc.test/fail_compilation/fail7424c.d: Update test. * gdc.test/fail_compilation/fail7424d.d: Update test. * gdc.test/fail_compilation/fail7424e.d: Update test. * gdc.test/fail_compilation/fail7424f.d: Update test. * gdc.test/fail_compilation/fail7424g.d: Update test. * gdc.test/fail_compilation/fail7424h.d: Update test. * gdc.test/fail_compilation/fail7424i.d: Update test. * gdc.test/compilable/test22133.d: New test. * gdc.test/fail_compilation/fail22133.d: New test. (cherry picked from commit 3e21361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12897.