[dmd-cxx] fix issue 19002 - __FUNCTION__ and __PRETTY_FUNCTION__ cannot be used as C string literals #12923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "dmd-cxx + dmd#12923" |
WalterBright
approved these changes
Jul 26, 2021
…ot be used as C string literals
nstester
pushed a commit
to nstester/gcc
that referenced
this pull request
Jul 28, 2021
…t (PR101441) Backports fix from upstream to allow __FUNCTION__ and __PRETTY_FUNCTION__ to be used as C string literals. Reviewed-on: dlang/dmd#12923 PR d/101441 gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd f8c1ca928.
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jul 28, 2021
…t (PR101441) Backports fix from upstream to allow __FUNCTION__ and __PRETTY_FUNCTION__ to be used as C string literals. Reviewed-on: dlang/dmd#12923 PR d/101441 gcc/d/ChangeLog: * dmd/expression.c (FuncInitExp::resolveLoc): Set type as `string'. (PrettyFuncInitExp::resolveLoc): Likewise. gcc/testsuite/ChangeLog: * gdc.test/compilable/b19002.d: New test. (cherry picked from commit 1a2306f)
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jul 28, 2021
…t (PR101441) Backports fix from upstream to allow __FUNCTION__ and __PRETTY_FUNCTION__ to be used as C string literals. Reviewed-on: dlang/dmd#12923 PR d/101441 gcc/d/ChangeLog: * dmd/expression.c (FuncInitExp::resolveLoc): Set type as `string'. (PrettyFuncInitExp::resolveLoc): Likewise. gcc/testsuite/ChangeLog: * gdc.test/compilable/b19002.d: New test. (cherry picked from commit 1a2306f)
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jul 28, 2021
…t (PR101441) Backports fix from upstream to allow __FUNCTION__ and __PRETTY_FUNCTION__ to be used as C string literals. Reviewed-on: dlang/dmd#12923 PR d/101441 gcc/d/ChangeLog: * dmd/expression.c (FuncInitExp::resolveLoc): Set type as `string'. (PrettyFuncInitExp::resolveLoc): Likewise. gcc/testsuite/ChangeLog: * gdc.test/compilable/b19002.d: New test. (cherry picked from commit 1a2306f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9920 for PR d/101441.