Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21667 - scope parameter causes 'no size because of forward refere… #14561

Merged
merged 1 commit into from Apr 17, 2023

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Oct 14, 2022

…nces'

Don't strip away scope in type semantic since it leads to forward reference errors. escape.d checks for hasPointers() on escaping variables anyway.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21667 normal scope parameter causes 'no size because of forward references'

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14561"

@dkorpel dkorpel marked this pull request as ready for review March 11, 2023 13:56
@RazvanN7
Copy link
Contributor

@dkorpel when you revive older PRs please ping me otherwise I might miss them.

@RazvanN7 RazvanN7 merged commit 8f9e710 into dlang:master Apr 17, 2023
41 checks passed
@dkorpel dkorpel deleted the scope-fwdref branch April 17, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix dip1000 memory safety with scope, ref, return stalled
Projects
None yet
3 participants