Extract expression.resolveLoc and move it to expressionsem #15782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15782" |
thewilsonator
approved these changes
Nov 7, 2023
|
Merge conflicts |
RazvanN7
force-pushed
the
move_exp_sema13
branch
from
11e1b1a
to
50f332c
Compare
|
Fixed. |
RazvanN7
changed the title
veelo
added a commit
to veelo/dmd
that referenced
this pull request
Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41. Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin dlang#15782.
veelo
added a commit
to veelo/dmd
that referenced
this pull request
Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41. Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin dlang#15782.
veelo
added a commit
to veelo/dmd
that referenced
this pull request
Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41. Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin dlang#15782.
thewilsonator
pushed a commit
that referenced
this pull request
Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41. Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin #15782.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.