Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print module names and timings when running unittests. #15795

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxhaton
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @maxhaton!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15795"

@maxhaton
Copy link
Member Author

Hijacking CI to see what this affects in the test suite

@maxhaton maxhaton changed the title Unittest fiddle Print module names and timings when running unittests. Nov 11, 2023
@maxhaton
Copy link
Member Author

@thewilsonator atila approved, I'm just checking that the test suite has anything to say. Something failed before but could've been flake

@maxhaton
Copy link
Member Author

I think the fail is legit but can't work out what

@maxhaton
Copy link
Member Author

module unittest_assert: FAILED in 73.000000 µs

ah ha

…ning them.

We cannot print which tests run due to architectural silliness but this is better than nothing.
@PetarKirov
Copy link
Member

@maxhaton can you add a screenshot to the PR description for future reference? I think users would also appreciate a changelog entry.

@RazvanN7
Copy link
Contributor

@maxhaton have you figured out what is the cause of the testing pipeline failure? This is a cool feature and it would be neat to get this in.

@maxhaton
Copy link
Member Author

@maxhaton have you figured out what is the cause of the testing pipeline failure? This is a cool feature and it would be neat to get this in.

I'm basically fixing the test suite first.

@RazvanN7
Copy link
Contributor

RazvanN7 commented Aug 7, 2024

@maxhaton any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants