-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Adapt to generic Makefile for Phobos #15920
Conversation
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15920" |
@@ -375,6 +375,8 @@ void setDefaultLibrary(ref Param params, const ref Target target) | |||
|
|||
if (driverParams.debuglibname is null) | |||
driverParams.debuglibname = driverParams.defaultlibname; | |||
else if (!driverParams.debuglibname.length) // if `-debuglib=` (i.e. an empty debuglib) | |||
driverParams.debuglibname = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a slipstreamed fix for dmd -g -debuglib= foo.d
causing an invalid /DEFAULTLIB:
linker flag for link.exe
, which complains about a missing name. The same logic is used for -defaultlib=
a few lines up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The Phobos Makefile specifies -defaultlib= -debuglib=
to make sure no default Phobos library is linked.)
Why was this merged without waiting for all pipelines to succeed? |
Because of a mutual two way dependance on dlang/phobos#8862 which you merged |
And then I retriggered CI here to confirm that was the case. |
Depends on dlang/phobos#8862 (vice-versa).