Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce version() which disables memory-greedy unittests #16141

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Feb 3, 2024

Adds ability to run unittests on systems in which there are <= 128Kb of the RAM

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16141"

@dkorpel
Copy link
Contributor

dkorpel commented Feb 5, 2024

It needs to be documented what this version identifier means exactly.

@denizzzka
Copy link
Contributor Author

I'm havent find appropriate place for the description

Also, I see self described names like DRuntime_Use_Libunwind. Maybe someone can suggest a similar self-describing name for this version?

@dkorpel
Copy link
Contributor

dkorpel commented Feb 5, 2024

I think the name is good, but consider someone encountering the version identifier a few years down the line. They will search for the codebase for the identifier and find only a few uses, but no explanation and no tests. Nowhere is the version set, so a reasonable conclusion is that's it's a relic for some old hardware that's no longer relevant, so it can be removed.

I'm constantly finding relics myself and questioning what they're for. A little explanation goes a long way in helping future contributors.

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this because it's harmless and you clearly have a use case for it, but do note that there's little stopping someone from adding new tests using lots of RAM, or removing the version in the future.

@denizzzka
Copy link
Contributor Author

@dkorpel

but do note that there's little stopping someone from adding new tests using lots of RAM, or removing the version in the future.

Sure, but when I found it I can add this dedicated version to such tests too

@dkorpel dkorpel merged commit 6f9c6bf into dlang:master Feb 6, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants