-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce version() which disables memory-greedy unittests #16141
Conversation
Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16141" |
64efd2b
to
254fd67
Compare
It needs to be documented what this version identifier means exactly. |
I'm havent find appropriate place for the description Also, I see self described names like |
I think the name is good, but consider someone encountering the version identifier a few years down the line. They will search for the codebase for the identifier and find only a few uses, but no explanation and no tests. Nowhere is the version set, so a reasonable conclusion is that's it's a relic for some old hardware that's no longer relevant, so it can be removed. I'm constantly finding relics myself and questioning what they're for. A little explanation goes a long way in helping future contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with merging this because it's harmless and you clearly have a use case for it, but do note that there's little stopping someone from adding new tests using lots of RAM, or removing the version in the future.
Sure, but when I found it I can add this dedicated version to such tests too |
Adds ability to run unittests on systems in which there are <= 128Kb of the RAM