Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA Windows: Make sure building compiler/druntime/Phobos does NOT need an MSVC env anymore #16287

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Mar 3, 2024

After #16248.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16287"

@kinke kinke changed the title GHA Windows: Make sure building compiler/druntime/Phobos does NOT need an MSVC env anymore Windows CI: Make sure building compiler/druntime/Phobos does NOT need an MSVC env anymore Mar 3, 2024
@kinke kinke changed the title Windows CI: Make sure building compiler/druntime/Phobos does NOT need an MSVC env anymore GHA Windows: Make sure building compiler/druntime/Phobos does NOT need an MSVC env anymore Mar 3, 2024
@thewilsonator thewilsonator merged commit 5d4f4e1 into dlang:master Mar 4, 2024
48 checks passed
@kinke kinke deleted the gha_msvc_env branch March 4, 2024 12:59
@kinke kinke mentioned this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants