Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a note #16472

Closed
wants to merge 2 commits into from
Closed

Adding a note #16472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6313e1c
Adding a note
trikko May 11, 2024
002fc0e
Update importc.h
thewilsonator May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions druntime/src/importc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ typedef unsigned long long __uint64_t;

// This header disables the Windows API Annotations macros
// Need to include sal.h to get the pragma once to prevent macro redefinition.
// Note: these includes require include paths to `cl.exe` as envoronment variables that are set by
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Gitbub actions
Copy link
Member

@maxhaton maxhaton May 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Gitbub actions
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Github actions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, but this should get overwritten at some point anyway.

// This will cause the compilation to fail (error C1083) if the environment has not been properly configured prior.
#include "sal.h"
#include "no_sal2.h"
#endif
Expand Down
Loading