Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove errors.d from mars.d #16565

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

WalterBright
Copy link
Member

More elimination of reliance on globals.

Eliminating the calls to fatal() makes it more tractable as a library.

@WalterBright WalterBright added Easy Review Refactoring No semantic changes to code labels Jun 6, 2024
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16565"

@WalterBright
Copy link
Member Author

I have no idea what this is about:

ERROR: Found the following residual temporary files.
ERROR: Temporary files should be stored in `test_results` or explicitly removed.
?? compiler/test/test14894a
make: *** [Makefile:120: check-clean-git] Error 1

* Returns:
* true on error
*/
extern (C++) bool generateJson(ref Modules modules, ErrorSink eSink)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is forward declared in LDC, but unused, and not in a header.
fyi @ibuclaw

Does this still need to be extern(C++)?

@WalterBright
Copy link
Member Author

Sigh. Looks like I'll have to do a binary search to find the problem!

@WalterBright WalterBright merged commit 2df43f9 into dlang:master Jun 6, 2024
41 checks passed
@WalterBright WalterBright deleted the marsEsink branch June 6, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Review Refactoring No semantic changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants