Issue 12888 - Include template constraints in JSON output #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| property("constraint", expression->toChars()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd prefer to move the position of "constraint" after "parameters", because it is consistent with actual D code.
template Name(Parameters...) if (constraint) { ...members... }
There was a problem hiding this comment.
Is this a request or a requirement? According to the JSON specification "An object is an unordered set of name/value pairs."
There was a problem hiding this comment.
It's not required for JSON data, but important for clean output from dmd.
|
Other than that, looks good. |
|
Ping? |
|
Auto-merge toggled on |
|
Oh wait @9rnsr had a concern. @Hackerpilot ? |
|
Auto-merge toggled off |
|
Updated. |
|
I was waiting the reply about 8 months. |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Jan 28, 2015
Issue 12888 - Include template constraints in JSON output
ibuclaw
pushed a commit
to ibuclaw/dmd
that referenced
this pull request
Jul 10, 2022
merge stable Signed-off-by: Iain Buclaw <ibuclaw@users.noreply.github.com> Merged-on-behalf-of: Iain Buclaw <ibuclaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=12888